feat: Metadata propagation in source, source transformer, mapper, sink #210
+1,211
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vtiwari5 <[email protected]>
vaibhavtiwari33
changed the title
Signed-off-by: vtiwari5 <[email protected]>
Signed-off-by: vtiwari5 <[email protected]>
… transform, mapper and sinker Signed-off-by: Vaibhav Tiwari <[email protected]>
yhl25
reviewed
Jan 27, 2026
Contributor
yhl25
left a comment
yhl25
left a comment
There was a problem hiding this comment.
- Use function overloading and introduce a method for constructing on success response using the
Datum. - Remove onSuccess function for proto and use a private method.
- Add an example(could be a follow-up PR).
Signed-off-by: Vaibhav Tiwari <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]>
yhl25
reviewed
Jan 28, 2026
| log.info("Writing to onSuccess sink: {}", datum.getId()); | ||
| // Build the onSuccess message using builder for changing values, keys or userMetadata | ||
| responseListBuilder.addResponse(Response.responseOnSuccess(datum.getId(), | ||
| Message.builder() |
Contributor
There was a problem hiding this comment.
Value is a mandatory field, lets stick to constructor now. We can add support for builders eventually.
| * @param message The message object to convert into the relevant proto object | ||
| * @return The converted proto object | ||
| */ | ||
| public static SinkOuterClass.SinkResponse.Result.Message toProto(Message message) { |
Contributor
There was a problem hiding this comment.
we don't need expose this to users, Can we make it package private or move to a dedicate private helper method?
| */ | ||
| public static Response responseOnSuccess(String id, SinkResponse.Result.Message onSuccessMessage) { | ||
| return new Response(id, false, null, false, false, null, true, onSuccessMessage); | ||
| public static Response responseOnSuccess(Datum datum) { |
Contributor
There was a problem hiding this comment.
Since we already have Message.fromDatum. I think this can be avoided.
Comment on lines
+103
to
+115
| @Test | ||
| public void testAddKV_ignoresNulls() { | ||
| UserMetadata metadata = new UserMetadata(); | ||
|
|
||
| metadata.addKV(null, "k", "v".getBytes()); | ||
| metadata.addKV("g", null, "v".getBytes()); | ||
| metadata.addKV("g", "k", null); | ||
|
|
||
| assertTrue(metadata.getGroups().isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testAddKV_defensiveCopy() { |
Contributor
There was a problem hiding this comment.
merge tests to cover different cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #205
Notes
Change in OnSuccess message metadata
With the introduction of a shared
UserMetadataclass, theuserMetadatamember inMessageclass for OnSuccess message has been changed from:to
This is done so that the users can utilize the same UserMetadata for onSuccess message without conversion.
Furthermore, the new UserMetadata has been implemented in its current form since it allows parity with other SDKs (inner data holds Map of Map, instead of Map of KeyValueGroup) and also prevents the extra step of converting proto KeyValueGroup object to local KeyValueGroup class object and back.
Format of userMetadata and systemMetadata
Both
UserMetadataandSystemMetadataclasses have inner data in the format: